[ https://issues.apache.org/jira/browse/FLEX-35123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15488391#comment-15488391 ]
Brian Martin commented on FLEX-35123: ------------------------------------- What version was this tested on? > DOM XSS vulnerability in history.js > ----------------------------------- > > Key: FLEX-35123 > URL: https://issues.apache.org/jira/browse/FLEX-35123 > Project: Apache Flex > Issue Type: Bug > Reporter: Aron Nopanen > Attachments: 0001-Address-DOM-XSS-vulnerability.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > Template file history.js contains a DOM XSS vulnerability. While it looks > like it would be difficult to exploit, it should be addressed. > The code in question is in a block specific to ancient versions of Safari (<= > 2.0.4), so I propose that block could safely be removed entirely. > The vulnerable line is: > getFormElement().innerHTML = '<form name="historyForm" action="'+file+'#' + > flexAppUrl + '" method="GET"></form>'; > The variables 'file' and 'flexAppUrl' are being passed unescaped into HTML > subcontext. > I'm attaching a patch that would remove the Safari-specific handling, > including the vulnerable line. -- This message was sent by Atlassian JIRA (v6.3.4#6332)