[
https://issues.apache.org/jira/browse/FLINK-1328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14277815#comment-14277815
]
ASF GitHub Bot commented on FLINK-1328:
---------------------------------------
GitHub user fhueske opened a pull request:
https://github.com/apache/flink/pull/311
[FLINK-1328] Reworked semantic annotations
This PR is based on #83
Open Issues:
- Naming of class annotations (`ConstantFields`, `ConstantFieldsExcept`,
`ReadFields`, ...) and API methods (`withConstantSet()`, ...). Constant fields
and constant set is a bit inconsistent. Do we want to keep the term *constant*
or should we go with preserved or forwarded fields? Right now, the original
naming is preserved.
- Documentation except for JavaDocs not done yet.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fhueske/flink constantFields
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/311.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #311
----
commit 25af81509c997b1f6748447db97bfe59322dde73
Author: sebastian kunert <[email protected]>
Date: 2014-08-31T17:22:56Z
integrated forwarded Fields into the optimizer
commit e6fb7116e3c0cbf2b615f0f3f580aa37707df3d3
Author: Fabian Hueske <[email protected]>
Date: 2014-12-17T17:59:14Z
[FLINK-1328] Reworked semantic annotations for functions.
- Constant fields can be defined for (nested) tuples, Pojos, case classes
- Added semantic function information to example programs
commit a6f50ac7238507c8bb8b8c1739170fa95ca8e7d6
Author: Fabian Hueske <[email protected]>
Date: 2015-01-14T15:48:07Z
[FLINK-1328] Added previously failing semantic annotations to examples and
fixed them by enabling partitioning on AtomicTypes.
----
> Rework Constant Field Annotations
> ---------------------------------
>
> Key: FLINK-1328
> URL: https://issues.apache.org/jira/browse/FLINK-1328
> Project: Flink
> Issue Type: Improvement
> Components: Java API, Optimizer, Scala API
> Affects Versions: 0.7.0-incubating
> Reporter: Fabian Hueske
> Assignee: Fabian Hueske
>
> Constant field annotations are used by the optimizer to determine whether
> physical data properties such as sorting or partitioning are retained by user
> defined functions.
> The current implementation is limited and can be extended in several ways:
> - Fields that are copied to other positions
> - Field definitions for non-tuple data types (Pojos)
> There is a pull request (#83) that goes into this direction and which can be
> extended.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
