GitHub user hsaputra opened a pull request:
https://github.com/apache/flink/pull/324
Rename coGroupDataSet.scala to CoGroupDataSet.scala, and crossDataSet.scala
to CrossDataSet.scala
This PR contains changes to follow Scala style:
-) Rename coGroupDataSet.scala to CoGroupDataSet.scala, and
crossDataSet.scala to CrossDataSet.scala
-) Move the UnfinishedCoGroupOperation class into its own Scala file
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hsaputra/flink rename_coGroupDataSet_filename
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/324.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #324
----
commit 85d0dbfb506b954c53ece5ff8f825df5fbde1ed8
Author: Henry Saputra <[email protected]>
Date: 2015-01-19T22:52:30Z
Rename coGroupDataSet.scala to CoGroupDataSet.scala, and crossDataSet.scala
to CrossDataSet.scala
commit fa9f37c189e397458df4afd89af4a0025373ec84
Author: Henry Saputra <[email protected]>
Date: 2015-01-19T23:29:51Z
Move the UnfinishedCoGroupOperation class into its own Scala file.
The UnfinishedCoGroupOperation does not relate closely to CoGroupOperation
via sealed modifier so per Scala style guide [1] I propose to move it to
separate file.
[1] http://docs.scala-lang.org/style/files.html
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
