[ 
https://issues.apache.org/jira/browse/FLINK-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291796#comment-14291796
 ] 

ASF GitHub Bot commented on FLINK-1330:
---------------------------------------

Github user uce commented on a diff in the pull request:

    https://github.com/apache/flink/pull/333#discussion_r23528552
  
    --- Diff: flink-dist/pom.xml ---
    @@ -436,6 +436,37 @@ under the License.
                                        </gitDescribe>
                                </configuration>
                        </plugin>
    +
    +                   <!-- create a symbolic link to the build target in the 
root directory -->
    +                   <plugin>
    +                           <groupId>com.pyx4j</groupId>
    +                           <artifactId>maven-junction-plugin</artifactId>
    +                           <version>1.0.3</version>
    +                           <executions>
    +                                   <execution>
    +                                           <phase>package</phase>
    +                                           <goals>
    +                                                   <goal>link</goal>
    +                                           </goals>
    +                                   </execution>
    +                                   <execution>
    +                                           <id>unlink</id>
    +                                           <phase>clean</phase>
    +                                           <goals>
    +                                                   <goal>unlink</goal>
    +                                           </goals>
    +                                   </execution>
    +                           </executions>
    +                           <configuration>
    +                                   <links>
    +                                           <link>
    +                                                   
<dst>${basedir}/../build-target</dst>
    --- End diff --
    
    I couldn't find a document stating that $basedir is deprecated, but I think 
you are right in the sense that the project prefix is used for everything 
related to the POM of the project (I think in previous versions the (now 
deprecated) prefix was `pom` and both the `version` and `basedir` properties 
are "built-ins").
    
    We use $basedir in other places as well.


> Restructure directory layout
> ----------------------------
>
>                 Key: FLINK-1330
>                 URL: https://issues.apache.org/jira/browse/FLINK-1330
>             Project: Flink
>          Issue Type: Improvement
>          Components: Build System, Documentation
>            Reporter: Max Michels
>            Priority: Minor
>              Labels: usability
>
> When building Flink, the build results can currently be found under 
> "flink-root/flink-dist/target/flink-$FLINKVERSION-incubating-SNAPSHOT-bin/flink-$YARNVERSION-$FLINKVERSION-incubating-SNAPSHOT/".
> I think we could improve the directory layout with the following:
> - provide the bin folder in the root by default
> - let the start up and submissions scripts in bin assemble the class path
> - in case the project hasn't been build yet, inform the user
> The changes would make it easier to work with Flink from source.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to