[
https://issues.apache.org/jira/browse/FLINK-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14298798#comment-14298798
]
ASF GitHub Bot commented on FLINK-1463:
---------------------------------------
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/353
[FLINK-1463] Fix stateful/stateless Serializers and Comparators
Before, Serializers would announce whether they are stateful or not and
rely on RuntimeStatefulSerializerFactory to do the duplication.
Comparators, on the other hand, had a duplicate method that the user was
required to call.
This commit removes the statful/stateless property from Serializers but
instead introduces a duplicate() method, similar to Comparators, that
can return the same instance.
The two serializer factories are merged into one that always calls
duplicate() before returning a serializer.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aljoscha/flink serializer-factories-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/353.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #353
----
commit 91834fee239b372b9a39f3c8f89ecbe42e2ae23a
Author: Aljoscha Krettek <[email protected]>
Date: 2015-01-30T15:43:31Z
[FLINK-1463] Fix stateful/stateless Serializers and Comparators
Before, Serializers would announce whether they are stateful or not and
rely on RuntimeStatefulSerializerFactory to do the duplication.
Comparators, on the other hand, had a duplicate method that the user was
required to call.
This commit removes the statful/stateless property from Serializers but
instead introduces a duplicate() method, similar to Comparators, that
can return the same instance.
The two serializer factories are merged into one that always calls
duplicate() before returning a serializer.
----
> RuntimeStatefulSerializerFactory declares ClassLoader as transient but later
> tries to use it
> --------------------------------------------------------------------------------------------
>
> Key: FLINK-1463
> URL: https://issues.apache.org/jira/browse/FLINK-1463
> Project: Flink
> Issue Type: Bug
> Reporter: Aljoscha Krettek
>
> At least one user has seen an exception because of this. In theory, the
> ClassLoader is set again in readParametersFromConfig. But the way it is used
> in TupleComparatorBase, this method is never called.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
