[
https://issues.apache.org/jira/browse/FLINK-1484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14308540#comment-14308540
]
ASF GitHub Bot commented on FLINK-1484:
---------------------------------------
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/368#discussion_r24220454
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -125,6 +126,10 @@ Actor with ActorLogMessages with ActorLogging {
override def postStop(): Unit = {
log.info(s"Stopping job manager ${self.path}.")
+ // disconnect the registered task managers
+ instanceManager.getAllRegisteredInstances.asScala.foreach{
+ _.getTaskManager ! Disconnected("JobManager is stopping")}
+
for((e,_) <- currentJobs.values){
e.fail(new Exception("The JobManager is shutting down."))
--- End diff --
Since we are cleaning up messages, maybe remove "The" so it is consistent
with other messages.
> JobManager restart does not notify the TaskManager
> --------------------------------------------------
>
> Key: FLINK-1484
> URL: https://issues.apache.org/jira/browse/FLINK-1484
> Project: Flink
> Issue Type: Bug
> Reporter: Till Rohrmann
>
> In case of a JobManager restart, which can happen due to an uncaught
> exception, the JobManager is restarted. However, connected TaskManager are
> not informed about the disconnection and continue sending messages to a
> JobManager with a reseted state.
> TaskManager should be informed about a possible restart and cleanup their own
> state in such a case. Afterwards, they can try to reconnect to a restarted
> JobManager.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
