[
https://issues.apache.org/jira/browse/FLINK-1533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14318207#comment-14318207
]
ASF GitHub Bot commented on FLINK-1533:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/388
[FLINK-1533] [runtime] Fixes NPE in the scheduler
Adds checks to the method ```Scheduler.getFreeSubSlotForTask``` to handle
failed shared slot allocations. Before the slot was given to the
```SlotSharingGroupAssignment``` without checking that it is not null.
Consequently, a NullPointerException could occur in the
```SlotSharingGroupAssignment```.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink fixScheduler
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/388.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #388
----
commit 604728df38c860ab111d0a7bf2d19c71a0d30c67
Author: Till Rohrmann <[email protected]>
Date: 2015-02-12T13:51:45Z
[FLINK-1533] [runtime] Fixes NPE in the scheduler where the allocated
shared slots are not properly checked.
----
> NullPointerException in
> SlotSharingGroupAssignment.addSharedSlotAndAllocateSubSlot
> ----------------------------------------------------------------------------------
>
> Key: FLINK-1533
> URL: https://issues.apache.org/jira/browse/FLINK-1533
> Project: Flink
> Issue Type: Bug
> Reporter: Till Rohrmann
>
> The scheduler can fail with a NullPointerException if it is not possible to
> allocate a {{SharedSlot}} from an {{Instance}}. In the method
> {{Scheduler.getFreeSubSlotForTask}} the allocated {{SharedSlot}} is not
> checked that it is not null. This can cause a program to fail if there is a
> race condition in scheduling different tasks on the same instance.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
