[
https://issues.apache.org/jira/browse/FLINK-1556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14327632#comment-14327632
]
ASF GitHub Bot commented on FLINK-1556:
---------------------------------------
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/422
[FLINK-1556] Corrects faulty JobClient behaviour in case of a submission
failure
Corrects the behaviour of the ```JobClient``` in case of a submission
failure. The PR also contains test cases for the job submission.
Additionally, reworked how exceptions are transmitted from the
```JobManager``` to the ```JobClient```. They are directly wrapped into a
```akka.actor.Status.Failure``` and send to the ```JobClient```.
This PR is based on #419.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink fixSubmissionExceptions
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/422.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #422
----
commit 8cc604d61d75370972146333c5a016b5fcdddc77
Author: Till Rohrmann <trohrm...@apache.org>
Date: 2015-02-19T10:04:56Z
[FLINK-1584] [runtime][tests] Fixes TaskManagerFailsITCase by replacing the
TestingCluster with a ForkableFlinkMiniCluster
commit 8ecca959d2bf96fa8be1961b413f4a2c45cf50e1
Author: Till Rohrmann <trohrm...@apache.org>
Date: 2015-02-19T11:44:32Z
[FLINK-1556] [runtime] Fails jobs properly in case of a job submission
exception
Conflicts:
flink-runtime/src/test/scala/org/apache/flink/runtime/testingUtils/TestingUtils.scala
flink-tests/src/test/scala/org/apache/flink/api/scala/runtime/taskmanager/TaskManagerFailsITCase.scala
----
> JobClient does not wait until a job failed completely if submission exception
> -----------------------------------------------------------------------------
>
> Key: FLINK-1556
> URL: https://issues.apache.org/jira/browse/FLINK-1556
> Project: Flink
> Issue Type: Bug
> Reporter: Till Rohrmann
> Assignee: Till Rohrmann
>
> If an exception occurs during job submission the {{JobClient}} received a
> {{SubmissionFailure}}. Upon receiving this message, the {{JobClient}}
> terminates itself and returns the error to the {{Client}}. This indicates to
> the user that the job has been completely failed which is not necessarily
> true.
> If the user directly after such a failure submits another job, then it might
> be the case that not all slots of the formerly failed job are returned. This
> can lead to a {{NoRessourceAvailableException}}.
> We can solve this problem by waiting for the completion of the job failure in
> the {{JobClient}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
