Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/408#issuecomment-75249793
Hi @balidani! Thanks a lot for this PR! Gather-Sum-Apply will be an awesome
addition to Gelly ^^
Here come my comments:
- There's no need for Gather, Sum and Apply functions to implement
MapFunction, FlatJoinFunction, etc., since they are wrapped inside those in
GatherSumApplyIteration class. Actually, I would use the Rich* versions
instead, so that we can have access to open() and close() methods. You can look
at how `VertexCentricIteration` wraps the `VertexUpdateFunction` inside a
`RichCoGroupFunction`.
- With this small change above, we could also allow access to aggregators
and broadcast sets. This must be straight-forward to add (again look at
`VertexCentricIteration` for hints). We should also add `getName()`,
`setName()`, `getParallelism()`, `setParallelism()` methods to
`GatherSumApplyIteration`.
- Finally, it'd be great if you could add the tests you have as examples,
i.e. one for Greedy Graph Coloring and one for GSAShortestPaths.
Let me know if you have any doubts!
Thanks again :sunny:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
