Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/202#issuecomment-77127742
Thanks, I have two last requests, sorry for that.
Could you rename flink-generic to flink-language-binding-generic? The
problem is, that the package name is now flink-generic, it pops up like this in
maven central and so on without the information that it is actually a sub
package of flink-language-binding. This could be quite confusing.
In MapFunctin.py and FilterFunction.py you use map() and filter()
respectively. These operations are not lazy, i.e. in map() it does first apply
the user map-function to every element in the partition and then it collects
the results. This can become a problem if the input is very big. Instead we
should iterate over the iterator and output each element after mapping. This
keeps memory consumption low. Same applies to filter().
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
