Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/426#issuecomment-78276533
Hi, thanks for the update! This is really good progress!
I had a look at your code and noticed a few things apart from the inline
comments.
- PojoTypeInformation is unfortunately not serializable (as I had to learn
a few days ago myself) because ``java.lang.reflect.Field`` is not serializable.
So the InputFormat will not work if used in a complete Flink program. What you
need to do to get the IF working is to add member variables for the POJO class
and all field names. In the ``open()`` method you need to create the ``Field``
objects with ``clazz.getDeclaredField(fieldName)`` and use these fields in the
``readRecord`` method.
- Add (at least) two end-to-end tests for the Java API and the Scala API
that use the new Pojo feature. These tests will catch the TypeInformation
serialization problem.
Please don't hesitate to get in touch if you have any questions!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
