Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/466#issuecomment-79096322
@aljoscha @fhueske @hsaputra Thanks for the feedback. Some people suggested
that the name is confusing and that my pull request involved too much code
duplication. I propose to call the new operator `combineGroup` because it is a
combiner that works on Groups, just like the existing combiners in
`GroupReduceCombineDriver` and `AllGroupReduceDriver`. I refactored the code to
reuse Flink's existing logic for combiners.
@hsaputra I added documentation for the operator in the code and the
official documentation. Some Scala tests for the API were added as well.
When merging this pull request, I would squash the two commits and keep the
commit message of the latest one. I simply wanted to keep the first one to show
the development process.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
