[
https://issues.apache.org/jira/browse/FLINK-1622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14360794#comment-14360794
]
ASF GitHub Bot commented on FLINK-1622:
---------------------------------------
Github user hsaputra commented on a diff in the pull request:
https://github.com/apache/flink/pull/466#discussion_r26407753
--- Diff:
flink-compiler/src/main/java/org/apache/flink/compiler/operators/GroupCombineProperties.java
---
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.compiler.operators;
+
+import org.apache.flink.api.common.operators.Order;
+import org.apache.flink.api.common.operators.Ordering;
+import org.apache.flink.api.common.operators.util.FieldSet;
+import org.apache.flink.compiler.dag.SingleInputNode;
+import org.apache.flink.compiler.dataproperties.GlobalProperties;
+import org.apache.flink.compiler.dataproperties.LocalProperties;
+import org.apache.flink.compiler.dataproperties.PartitioningProperty;
+import org.apache.flink.compiler.dataproperties.RequestedGlobalProperties;
+import org.apache.flink.compiler.dataproperties.RequestedLocalProperties;
+import org.apache.flink.compiler.plan.Channel;
+import org.apache.flink.compiler.plan.SingleInputPlanNode;
+import org.apache.flink.runtime.operators.DriverStrategy;
+
+import java.util.Collections;
+import java.util.List;
+
+public final class GroupCombineProperties extends OperatorDescriptorSingle
{
--- End diff --
Could you add JavaDoc for this class? I know other derived classes for
OperatorDescriptorSingle does not have JavaDoc, yet but I am trying to get new
code added to have at least simple explanation why the class should be created.
> Add GroupReducePartial Operator
> -------------------------------
>
> Key: FLINK-1622
> URL: https://issues.apache.org/jira/browse/FLINK-1622
> Project: Flink
> Issue Type: Sub-task
> Affects Versions: 0.9
> Reporter: Aljoscha Krettek
>
> This does what a Reduce or GroupReduce Operator does, except it is only
> performed on a local partition.
> This is also similar to an explicit combine that can output a type that is
> different from the input.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
