[ 
https://issues.apache.org/jira/browse/FLINK-1641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14364465#comment-14364465
 ] 

ASF GitHub Bot commented on FLINK-1641:
---------------------------------------

GitHub user ggevay opened a pull request:

    https://github.com/apache/flink/pull/489

    [FLINK-1641] Make projection operator chainable.

    I tested this by adding a dummy project to the WordCount example, by adding
    .project(0, 1).types(String.class, Integer.class)
    to line 70.
    Without the chaining modification, the log looks like this:
    Deploying Grouped Aggregation (4/4) (attempt #0) to localhost
    Deploying Projection -> Stream Sink (4/4) (attempt #0) to localhost
    And with the modification, it looks like this:
    Deploying Grouped Aggregation -> Projection -> Stream Sink (4/4) (attempt 
#0) to localhost
    If I read this correctly, then it means that it was chained as expected. 
Should I also create an automated test for this?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ggevay/flink master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/489.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #489
    
----
commit 933315130876ab986d6d0ffde2f7c7d400c9d34e
Author: Gabor Gevay <gga...@gmail.com>
Date:   2015-03-17T02:02:35Z

    [FLINK-1641] Make projection operator chainable.

----


> Make projection operator chainable
> ----------------------------------
>
>                 Key: FLINK-1641
>                 URL: https://issues.apache.org/jira/browse/FLINK-1641
>             Project: Flink
>          Issue Type: Improvement
>          Components: Streaming
>            Reporter: Gyula Fora
>            Assignee: Gabor Gevay
>
> The ProjectInvokable currently doesn't extend the ChainableInvokable class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to