[ https://issues.apache.org/jira/browse/FLINK-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14372966#comment-14372966 ]
ASF GitHub Bot commented on FLINK-1766: --------------------------------------- Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/511#issuecomment-84423820 Looks good. This seems more like an optimization, than a bug, Before we can merge the change, it needs to be brought in sync with the code style. Currently, the checkstyle rules reject the code for using spaces rather than tabs. > Fix the bug of equals function of FSKey > --------------------------------------- > > Key: FLINK-1766 > URL: https://issues.apache.org/jira/browse/FLINK-1766 > Project: Flink > Issue Type: Bug > Reporter: Sibao Hong > Priority: Minor > > The equals function in org.apache.flink.core.fs.FileSystem.FSKey should first > have a confirm whether obj == this, if obj is the same object.It should > return True. -- This message was sent by Atlassian JIRA (v6.3.4#6332)