[ https://issues.apache.org/jira/browse/FLINK-1512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14377681#comment-14377681 ]
ASF GitHub Bot commented on FLINK-1512: --------------------------------------- Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/426#discussion_r27018151 --- Diff: flink-scala/src/main/java/org/apache/flink/api/scala/operators/ScalaCsvInputFormat.java --- @@ -98,98 +123,66 @@ public void setFields(int[] sourceFieldIndices, Class<?>[] fieldTypes) { setFieldsGeneric(sourceFieldIndices, fieldTypes); } - public byte[] getCommentPrefix() { - return commentPrefix; - } - - public void setCommentPrefix(byte[] commentPrefix) { - this.commentPrefix = commentPrefix; - } - - public void setCommentPrefix(char commentPrefix) { - setCommentPrefix(String.valueOf(commentPrefix)); - } + public void setFields(boolean[] sourceFieldMask, Class<?>[] fieldTypes) { + Preconditions.checkNotNull(sourceFieldMask); + Preconditions.checkNotNull(fieldTypes); - public void setCommentPrefix(String commentPrefix) { - setCommentPrefix(commentPrefix, Charsets.UTF_8); + setFieldsGeneric(sourceFieldMask, fieldTypes); } - public void setCommentPrefix(String commentPrefix, String charsetName) throws IllegalCharsetNameException, UnsupportedCharsetException { - if (charsetName == null) { - throw new IllegalArgumentException("Charset name must not be null"); - } - - if (commentPrefix != null) { - Charset charset = Charset.forName(charsetName); - setCommentPrefix(commentPrefix, charset); - } else { - this.commentPrefix = null; - } + public Class<?>[] getFieldTypes() { + return super.getGenericFieldTypes(); } - public void setCommentPrefix(String commentPrefix, Charset charset) { - if (charset == null) { - throw new IllegalArgumentException("Charset must not be null"); - } - if (commentPrefix != null) { - this.commentPrefix = commentPrefix.getBytes(charset); - } else { - this.commentPrefix = null; - } - } - - @Override - public void close() throws IOException { --- End diff -- Did the `close()` method got lost in the refactoring? > Add CsvReader for reading into POJOs. > ------------------------------------- > > Key: FLINK-1512 > URL: https://issues.apache.org/jira/browse/FLINK-1512 > Project: Flink > Issue Type: New Feature > Components: Java API, Scala API > Reporter: Robert Metzger > Assignee: Chiwan Park > Priority: Minor > Labels: starter > > Currently, the {{CsvReader}} supports only TupleXX types. > It would be nice if users were also able to read into POJOs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)