Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/534#discussion_r27100141
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/streamvertex/StreamVertex.java
---
@@ -283,16 +288,18 @@ public StreamConfig getConfig() {
*
* @param id
*/
- private void actOnBarrier(long id) {
- try {
- outputHandler.broadcastBarrier(id);
- // TODO checkpoint state here
- confirmBarrier(id);
- if (LOG.isDebugEnabled()) {
- LOG.debug("Superstep " + id + " processed: " +
StreamVertex.this);
+ private synchronized void actOnBarrier(long id) {
+ if (this.isRunning) {
+ try {
+ outputHandler.broadcastBarrier(id);
+ // TODO checkpoint state here
+ confirmBarrier(id);
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("Superstep " + id + "
processed: " + StreamVertex.this);
+ }
+ } catch (Exception e) {
+ // TODO:Figure this out properly
--- End diff --
Why are you swallowing the exception here silently?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
