[
https://issues.apache.org/jira/browse/FLINK-1741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14387398#comment-14387398
]
ASF GitHub Bot commented on FLINK-1741:
---------------------------------------
Github user andralungu commented on the pull request:
https://github.com/apache/flink/pull/544#issuecomment-87830769
Hi @vasia ,
The problem(at least mine) was that Jaccard works on both an undirected and
on a directed graph... and I just needed to make a final decision :). Directed
won today!
Next, I see why you wanted reduceOnEdges, I used it, but there's a small
glitch there(in EmitOneEdgePerNode) that the test doesn't catch. I solved the
problem in a not-so-elegant way for now, because I think that solving the
problem should be a separate JIRA issue(it has nothing to do with Jaccard).
So my suggestion is: we merge the code with the if statement; I open a bug,
fix reduceOnEdges to work for this usecase as well and then everything will
look nice and clean.
What do you think?
> Add Jaccard Similarity Metric Example
> -------------------------------------
>
> Key: FLINK-1741
> URL: https://issues.apache.org/jira/browse/FLINK-1741
> Project: Flink
> Issue Type: Task
> Components: Gelly
> Affects Versions: 0.9
> Reporter: Andra Lungu
> Assignee: Andra Lungu
>
> http://www.inside-r.org/packages/cran/igraph/docs/similarity
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
