[ 
https://issues.apache.org/jira/browse/FLINK-951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14396386#comment-14396386
 ] 

ASF GitHub Bot commented on FLINK-951:
--------------------------------------

Github user markus-h commented on the pull request:

    https://github.com/apache/flink/pull/570#issuecomment-89849730
  
    Thanks for your comments!
    I will try to revert my formattings. I am used to doing STRG+F while 
programming that probably changed the formatting.
    
    I also got rid of the Thread.sleep(). The problem was acutally a different 
one. Akka delivered the same response object to threads on the same machine, 
but I thought it would be copies. Now I do a hard copy of the response, that 
seems to fix the problem.
    
    I am not sure how to test the interaction between IterationHead and JM 
though. Is there some similiar testcase that I could use as a basis?



> Reworking of Iteration Synchronization, Accumulators and Aggregators
> --------------------------------------------------------------------
>
>                 Key: FLINK-951
>                 URL: https://issues.apache.org/jira/browse/FLINK-951
>             Project: Flink
>          Issue Type: Improvement
>          Components: Iterations, Optimizer
>    Affects Versions: 0.9
>            Reporter: Markus Holzemer
>            Assignee: Markus Holzemer
>              Labels: refactoring
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> I just realized that there is no real Jira issue for the task I am currently 
> working on. 
> I am currently reworking a few things regarding Iteration Synchronization, 
> Accumulators and Aggregators. Currently the synchronization at the end of one 
> superstep is done through channel events. That makes it hard to track the 
> current status of iterations. That is why I am changing this synchronization 
> to use RPC calls with the JobManager, so that the JobManager manages the 
> current status of all iterations.
> Currently we use Accumulators outside of iterations and Aggregators inside of 
> iterations. Both have a similiar function, but a bit different interfaces and 
> handling. I want to unify these two concepts. I propose that we stick in the 
> future to Accumulators only. Aggregators therefore are removed and 
> Accumulators are extended to cover the usecases Aggregators were used fore 
> before. The switch to RPC for iterations makes it possible to also send the 
> current Accumulator values at the end of each superstep, so that the 
> JobManager (and thereby the webinterface) will be able to print intermediate 
> accumulation results.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to