Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/572#issuecomment-90023731
@hsaputra Thanks for advice! I renamed `BasicKeySelector` to
`IdentityKeySelector` to prevent ambiguous naming. I added JavaDoc for
`IdentityKeySelector`.
BTW, I found some duplicated classes with `IdentityKeySelector`
([1](https://github.com/apache/flink/blob/master/flink-optimizer/src/test/java/org/apache/flink/optimizer/testfunctions/IdentityKeyExtractor.java),
[2](https://github.com/apache/flink/blob/master/flink-tests/src/test/java/org/apache/flink/test/iterative/StaticlyNestedIterationsITCase.java#L58),
[3](https://github.com/apache/flink/blob/master/flink-tests/src/test/java/org/apache/flink/test/misc/CustomPartitioningITCase.java#L67)).
Should I substitute the `IdentityKeySelector` for them? It will decrease the
amount of duplicated code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
