Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/589#discussion_r28227565
--- Diff:
flink-staging/flink-streaming/flink-streaming-connectors/src/main/java/org/apache/flink/streaming/connectors/kafka/api/KafkaSink.java
---
@@ -114,17 +132,24 @@ public KafkaSink(String zookeeperAddress, String
topicId,
public void open(Configuration configuration) {
KafkaTopicUtils kafkaTopicUtils = new
KafkaTopicUtils(zookeeperAddress);
- String brokerAddress =
kafkaTopicUtils.getLeaderBrokerAddressForTopic(topicId);
+ String listOfBrokers = kafkaTopicUtils.getBrokerList(topicId);
+
+ if (LOG.isInfoEnabled()) {
+ LOG.info("Broker list: {}", listOfBrokers);
+ }
- props = new Properties();
+ if (props == null) {
--- End diff --
How about always setting our default properties (broker list, max retries
etc.) and overwrite them with the properties passed by the users.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
