[ 
https://issues.apache.org/jira/browse/FLINK-703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14503045#comment-14503045
 ] 

ASF GitHub Bot commented on FLINK-703:
--------------------------------------

Github user chiwanpark commented on a diff in the pull request:

    https://github.com/apache/flink/pull/572#discussion_r28699341
  
    --- Diff: 
flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/GroupReduceITCase.java
 ---
    @@ -1063,6 +1065,33 @@ public void reduce(Iterable<Tuple5<Integer, Long, 
Integer, String, Long>> values
     
        }
     
    +   @Test
    +   public void testGroupReduceWithAtomicValue() throws Exception {
    +           final ExecutionEnvironment env = 
ExecutionEnvironment.getExecutionEnvironment();
    +           DataSet<Integer> ds = env.fromElements(1, 1, 2, 3, 4);
    +           DataSet<Integer> reduceDs = ds.groupBy("*").reduceGroup(new 
GroupReduceFunction<Integer, Integer>() {
    +                   @Override
    +                   public void reduce(Iterable<Integer> values, 
Collector<Integer> out) throws Exception {
    +                           Set<Integer> set = new HashSet<Integer>();
    +                           for (Integer i : values) {
    +                                   set.add(i);
    +                           }
    +                           for (Integer i : set) {
    +                                   out.collect(i);
    +                           }
    +                   }
    +           });
    +
    +           env.setParallelism(1);
    --- End diff --
    
    Oh, I just copied code from other test case. I will fix it :)


> Use complete element as join key.
> ---------------------------------
>
>                 Key: FLINK-703
>                 URL: https://issues.apache.org/jira/browse/FLINK-703
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: GitHub Import
>            Assignee: Chiwan Park
>            Priority: Trivial
>              Labels: github-import
>             Fix For: pre-apache
>
>
> In some situations such as semi-joins it could make sense to use a complete 
> element as join key. 
> Currently this can be done using a key-selector function, but we could offer 
> a shortcut for that.
> This is not an urgent issue, but might be helpful.
> ---------------- Imported from GitHub ----------------
> Url: https://github.com/stratosphere/stratosphere/issues/703
> Created by: [fhueske|https://github.com/fhueske]
> Labels: enhancement, java api, user satisfaction, 
> Milestone: Release 0.6 (unplanned)
> Created at: Thu Apr 17 23:40:00 CEST 2014
> State: open



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to