Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/612#discussion_r28814484
  
    --- Diff: 
flink-tests/src/test/java/org/apache/flink/test/recovery/AbstractProcessFailureRecoveryTest.java
 ---
    @@ -112,9 +112,9 @@ public void testTaskManagerProcessFailure() {
                        Tuple2<String, Object> localAddress = new 
Tuple2<String, Object>("localhost", jobManagerPort);
     
                        Configuration jmConfig = new Configuration();
    -                   
jmConfig.setString(ConfigConstants.AKKA_WATCH_HEARTBEAT_INTERVAL, "1 s");
    -                   
jmConfig.setString(ConfigConstants.AKKA_WATCH_HEARTBEAT_PAUSE, "4 s");
    -                   
jmConfig.setInteger(ConfigConstants.AKKA_WATCH_THRESHOLD, 2);
    +                   
jmConfig.setString(ConfigConstants.AKKA_WATCH_HEARTBEAT_INTERVAL, "1 ms");
    --- End diff --
    
    Is this really a good idea? Heartbeats every 1 ms? This is almost longer 
than the TCP process-to-process roundtrip time. May be a bit too aggressive...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to