Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/566#discussion_r29144391
  
    --- Diff: 
flink-core/src/main/java/org/apache/flink/types/parser/IntParser.java ---
    @@ -38,19 +38,28 @@ public int parseField(byte[] bytes, int startPos, int 
limit, byte[] delimiter, I
     
                final int delimLimit = limit-delimiter.length+1;
     
    +           if (bytes.length == 0) {
    --- End diff --
    
    This check is not strictly necessary, IMO.
    `bytes` is a larger byte array which is reused by the calling 
`GenericCsvInputFormat`.
    
    To reduce the processing overhead of each field, I would omit the check 
(here and in the Long and Short parsers)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to