Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/553#discussion_r29745454
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -1894,6 +1895,52 @@ object TaskManager {
override def getValue: Double =
ManagementFactory.getOperatingSystemMXBean().getSystemLoadAverage()
})
+ // Preprocessing steps for registering cpuLoad
+ // fetch the method to get process CPU load
+ val getCPULoadMethod: Method = getMethodToFetchCPULoad()
+
+ // Log getProcessCpuLoad method not available for Java 6
+ if(getCPULoadMethod == null){
+ LOG.warn("getProcessCpuLoad method not available in the Operating
System Bean" +
+ "implementation for this Java runtime
environment\n"+Thread.currentThread().getStackTrace)
+ }
+
+ // define the fetchCPULoad method as per the fetched getCPULoadMethod
+ val fetchCPULoad: (Any) => Double = if (getCPULoadMethod != null) {
+ (obj: Any) => getCPULoadMethod.invoke(obj).asInstanceOf[Double]
+ } else {
+ (obj: Any) => -1
+ }
+
+ metricRegistry.register("cpuLoad", new Gauge[Double] {
+ override def getValue: Double = {
+ try{
--- End diff --
why not doing:
```
val fetchCPULoad = getMethodToFetchCPULoad()
if(fetchCPULoad.isEmpty) { LOG.warn("Java 6 not supported ...") }
metricRegistry.register("cpuLoad", new Gauge[Double] {
override def getValue(): Double = {
try{
val osMXBean = ManagementFactory.getOperatinSystemMXBean()
fetchCPULoad.map(_.invoke(osMXBean))
}.getOrElse(-1)
} catch {
case t: Throwable => {
LOG.warn(....)
-1
}
}
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
