[ https://issues.apache.org/jira/browse/FLINK-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14532676#comment-14532676 ]
ASF GitHub Bot commented on FLINK-1977: --------------------------------------- Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/659#discussion_r29854205 --- Diff: flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/operators/co/CoStreamWindow.java --- @@ -174,21 +178,17 @@ public String toString() { } @Override - public void close() { + public void close() throws Exception { if (!window.miniBatchEnd()) { - callUserFunctionAndLogException(); + try { + callUserFunction(); + } catch (Exception e) { + throw new RuntimeException("Could not call user function in CoStreamWindow.close()"); --- End diff -- pass the exception to the RE? > Rework Stream Operators to always be push based > ----------------------------------------------- > > Key: FLINK-1977 > URL: https://issues.apache.org/jira/browse/FLINK-1977 > Project: Flink > Issue Type: Improvement > Reporter: Aljoscha Krettek > Assignee: Aljoscha Krettek > > This is a result of the discussion on the mailing list. This is an excerpt > from the mailing list that gives the basic idea of the change: > I propose to change all streaming operators to be push based, with a > slightly improved interface: In addition to collect(), which I would > call receiveElement() I would add receivePunctuation() and > receiveBarrier(). The first operator in the chain would also get data > from the outside invokable that reads from the input iterator and > calls receiveElement() for the first operator in a chain. -- This message was sent by Atlassian JIRA (v6.3.4#6332)