Github user thvasilo commented on the pull request:

    https://github.com/apache/flink/pull/656#issuecomment-100159626
  
    Thank you for the contribution Johaness. For the logistic loss could you 
change the implementation to match the approximate version that sklearn (and 
other libraries) use?
    
    You can see it 
[here](https://github.com/scikit-learn/scikit-learn/blob/master/sklearn/linear_model/sgd_fast.pyx#L202),
 this way we may save the computation of the log.
    @tillrohrmann Any objections to using this version?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to