[
https://issues.apache.org/jira/browse/FLINK-1980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14538486#comment-14538486
]
ASF GitHub Bot commented on FLINK-1980:
---------------------------------------
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/658#issuecomment-101024456
Looks good. One comment, though:
- The position tracking in the stream wrapper is a nice idea, but since
the `skip()` method is anyways only a hint (it may skip less if it wants) and
seeking works only in one direction, why not skip seek support completely? Also
simplifies the code and makes it even more lightweight.
As a followup: Should we add more built-in decompressors for other file
endings, like `*.gz` ?
> Allowing users to decorate input streams
> ----------------------------------------
>
> Key: FLINK-1980
> URL: https://issues.apache.org/jira/browse/FLINK-1980
> Project: Flink
> Issue Type: New Feature
> Components: Core
> Reporter: Sebastian Kruse
> Assignee: Sebastian Kruse
> Priority: Minor
>
> Users may have to do unforeseeable operations on file input streams before
> they can be used by the actual input format logic, e.g., exotic compression
> formats or preambles such as byte order marks. Therefore, it would be useful
> to provide the user with a hook to decorate input streams in order to handle
> such issues.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
