Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3714#discussion_r112226659 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/WindowAggregateTest.scala --- @@ -29,6 +29,27 @@ class WindowAggregateTest extends TableTestBase { private val streamUtil: StreamTableTestUtil = streamTestUtil() streamUtil.addTable[(Int, String, Long)]("MyTable", 'a, 'b, 'c) + + + @Test + def testSortProcessingTime() = { --- End diff -- I would add these tests to a new class `SortTest`. Please add also tests that check that unsupported operations (desc time sort, time field not primary sort field, etc.) throw an exception.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---