Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/3741
  
    Looks quite good now.
    
    If I can ask you for one more followup: To have faster tests, it would be 
good to add the streaming distributed cache test and the batch distributed 
cache test to the same file.
    
    Can you change the `DistributedCacheTest` to extend 
`StreamingMultipleProgramsTestBase` and put your test in there as well? That 
will cause only one distributed mini cluster to be spawned, which typically 
saves 1-2 secs in tests. May not seem much, but it adds up over the 1000s of 
tests Flink has by now...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to