Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112802168
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -267,38 +289,77 @@ public void close() throws Exception {
//
------------------------------------------------------------------------
@Override
- public HashMap<KinesisStreamShard, SequenceNumber> snapshotState(long
checkpointId, long checkpointTimestamp) throws Exception {
+ public void snapshotState(FunctionSnapshotContext context) throws
Exception {
if (lastStateSnapshot == null) {
LOG.debug("snapshotState() requested on not yet opened
source; returning null.");
- return null;
- }
-
- if (fetcher == null) {
+ } else if (fetcher == null) {
LOG.debug("snapshotState() requested on not yet running
source; returning null.");
- return null;
- }
-
- if (!running) {
+ } else if (!running) {
LOG.debug("snapshotState() called on closed source;
returning null.");
- return null;
- }
+ } else {
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("Snapshotting state ...");
+ }
- if (LOG.isDebugEnabled()) {
- LOG.debug("Snapshotting state ...");
- }
+ sequenceNumsStateForCheckpoint.clear();
+ lastStateSnapshot = fetcher.snapshotState();
- lastStateSnapshot = fetcher.snapshotState();
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("Snapshotted state, last processed
sequence numbers: {}, checkpoint id: {}, timestamp: {}",
+ lastStateSnapshot.toString(),
context.getCheckpointId(), context.getCheckpointTimestamp());
+ }
- if (LOG.isDebugEnabled()) {
- LOG.debug("Snapshotted state, last processed sequence
numbers: {}, checkpoint id: {}, timestamp: {}",
- lastStateSnapshot.toString(), checkpointId,
checkpointTimestamp);
+ for (Map.Entry<KinesisStreamShard, SequenceNumber>
entry : lastStateSnapshot.entrySet()) {
+
sequenceNumsStateForCheckpoint.add(Tuple2.of(entry.getKey(), entry.getValue()));
+ }
}
+ }
- return lastStateSnapshot;
+ @Override
+ public void initializeState(FunctionInitializationContext context)
throws Exception {
--- End diff --
I would recommend to change the order of the method declarations of
`initializeState` and `snapshotState` for a better read flow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
