[ 
https://issues.apache.org/jira/browse/FLINK-6361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15981477#comment-15981477
 ] 

ASF GitHub Bot commented on FLINK-6361:
---------------------------------------

GitHub user shaoxuan-wang opened a pull request:

    https://github.com/apache/flink/pull/3762

    [FLINK-6361] [table] Refactoring the AggregateFunction interface and 
built-in aggregates

    This PR includes the following changes:
    1) remove Accumulator trait; 
    2) move accumulate, retract, merge, resetAccumulator, getAccumulatorType 
methods out of AggregateFunction interface, and allow them to be defined as 
contracted methods for UDAGG; 
    3) refactoring the built-in aggregates accordingly.
    4) fixed a build warning in flink/table/api/Types.scala (unrelated to 
FLINK-6361)
    
    
    Thanks for contributing to Apache Flink. Before you open your pull request, 
please take the following check list into consideration.
    If your changes take all of the items into account, feel free to open your 
pull request. For more information and/or questions please refer to the [How To 
Contribute guide](http://flink.apache.org/how-to-contribute.html).
    In addition to going through the list, please provide a meaningful 
description of your changes.
    
    - [x] General
      - The pull request references the related JIRA issue ("[FLINK-XXX] Jira 
title text")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the 
JIRA id)
    
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [x] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis 
build has passed


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shaoxuan-wang/flink F6361-submit

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3762.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3762
    
----
commit b5806b1a3975186d69a76fd369ff77cf06e1e67f
Author: shaoxuan-wang <wshaox...@gmail.com>
Date:   2017-04-24T16:28:37Z

    [FLINK-6361] [table] Refactoring the AggregateFunction interface and 
built-in aggregates

----


> Finalize the AggregateFunction interface and refactoring built-in aggregates
> ----------------------------------------------------------------------------
>
>                 Key: FLINK-6361
>                 URL: https://issues.apache.org/jira/browse/FLINK-6361
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: Shaoxuan Wang
>            Assignee: Shaoxuan Wang
>
> We have completed codeGen for all aggregate runtime functions. Now we can 
> finalize the AggregateFunction. This includes 1) remove Accumulator trait; 2) 
> remove accumulate, retract, merge, resetAccumulator, getAccumulatorType 
> methods from interface, and allow them as contracted methods for UDAGG; 3) 
> refactoring the built-in aggregates accordingly.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to