[
https://issues.apache.org/jira/browse/FLINK-6392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15986023#comment-15986023
]
ASF GitHub Bot commented on FLINK-6392:
---------------------------------------
GitHub user sunjincheng121 opened a pull request:
https://github.com/apache/flink/pull/3786
[FLINK-6392][table] Change the alias of Window from optional to essen…
In this PR refactoring the API definition using TYPE SYSTEM lead to
constraint for the alias.
- [x] General
- The pull request references the related JIRA issue
("[FLINK-6392][table] Change the alias of Window from optional to essential.")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sunjincheng121/flink FLINK-6392-PR
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3786.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3786
----
commit a9a2c0e8473da287cb5f77ba48ed9d5048e6a3a7
Author: sunjincheng121 <sunjincheng...@gmail.com>
Date: 2017-04-27T01:58:18Z
[FLINK-6392][table] Change the alias of Window from optional to essential.
----
> Change the alias of Window from optional to essential.
> ------------------------------------------------------
>
> Key: FLINK-6392
> URL: https://issues.apache.org/jira/browse/FLINK-6392
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Affects Versions: 1.3.0
> Reporter: sunjincheng
> Assignee: sunjincheng
> Fix For: 1.3.0
>
>
> Currently, The window clause use case looks like as following:
> {code}
> tab //Table('a,'b,'c)
> .window( Slide over 10.milli every 5.milli as 'w)
> .groupBy('w,'a,'b)
> .select('a, 'b, 'c.sum, 'w.start, 'w.end)
> {code}
> As we see the alias of window is essential. But the current implementation of
> the TableAPI does not have the constraint for the alias,So we must
> refactoring the API definition using TYPE SYSTEM lead to constraint for the
> alias.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
