[ 
https://issues.apache.org/jira/browse/FLINK-5969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15987026#comment-15987026
 ] 

ASF GitHub Bot commented on FLINK-5969:
---------------------------------------

Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/3778
  
    Thanks @zentol! I addressed your (easily resolvable) comments.
    
    About unifying the functionality of the tests/ITCases, I was planning to to 
that for the upcoming `*From13` tests but for the `*From11` and `*From12` it's 
difficult because quite some stuff changed between 1.1 and 1.2 and I want the 
code to mostly work on all branches. For example, this is the new `*From12` 
tests rebased on the master branch: 
https://github.com/aljoscha/flink/tree/jira-5969-backwards-compat-12-13. By 
transplanting but keeping the snapshots that were generated on Flink 1.2.0 we 
get backwards compatibility tests while the tests in this PR test compatibility 
within Flink 1.2.x. 
    
    I'm hoping that for the future we can move to a base class and version 
specific tests. I'll also think about how much is possible right now and try 
and simplify/unify.


> Add savepoint backwards compatibility tests from 1.2 to 1.3
> -----------------------------------------------------------
>
>                 Key: FLINK-5969
>                 URL: https://issues.apache.org/jira/browse/FLINK-5969
>             Project: Flink
>          Issue Type: Improvement
>          Components: Tests
>    Affects Versions: 1.3.0
>            Reporter: Aljoscha Krettek
>            Assignee: Aljoscha Krettek
>            Priority: Blocker
>             Fix For: 1.3.0
>
>
> We currently only have tests that test migration from 1.1 to 1.3, because we 
> added these tests when releasing Flink 1.2.
> We have to copy/migrate those tests:
>  - {{StatefulUDFSavepointMigrationITCase}}
>  - {{*MigrationTest}}
>  - {{AbstractKeyedCEPPatternOperator}}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to