Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/3785#discussion_r113905412
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/misc/SuccessAfterNetworkBuffersFailureITCase.java
---
@@ -68,7 +68,6 @@ public void testSuccessfulProgramAfterFailure() {
try {
runKMeans(cluster.getLeaderRPCPort());
- fail("This program execution should have
failed.");
--- End diff --
I think that the idea of the test is to check that another program can be
executed after one failed. The commit message introducing the test says "This
test validates that task slots in co-location constraints are properly freed in
the presence of failures." By removing this line, we are not testing what we
actually wanted to test anymore. We should keep the line but instead decrease
the number of configured buffers, for example 640 works instead of 840. That
way we keep the behaviour: successful job, failed job, successful job.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
