[ 
https://issues.apache.org/jira/browse/FLINK-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15989135#comment-15989135
 ] 

Greg Hogan commented on FLINK-6414:
-----------------------------------

[~StephanEwen], [this|https://github.com/apache/flink/pull/885] is the genesis 
for borrowing Spark's {{change-scala-version.sh}} and I'm not seeing the 
referenced issues. Travis is passing and Maven is installing the artifacts 
locally just fine. The one glitch I am seeing is these cases where 
maven-remote-resources-plugin is downloading 2.10 resources for the 2.11 build:

{noformat}
[INFO] --- maven-remote-resources-plugin:1.5:process (process-resource-bundles) 
@ flink-tests_2.11 ---
Downloading: 
https://repository.apache.org/snapshots/org/apache/flink/flink-clients_2.10/1.3-SNAPSHOT/maven-metadata.xml
Downloaded: 
https://repository.apache.org/snapshots/org/apache/flink/flink-clients_2.10/1.3-SNAPSHOT/maven-metadata.xml
 (1.4 kB at 16 kB/s)
Downloading: 
https://repository.apache.org/snapshots/org/apache/flink/flink-clients_2.10/1.3-SNAPSHOT/flink-clients_2.10-1.3-20170428.120310-111.pom
Downloaded: 
https://repository.apache.org/snapshots/org/apache/flink/flink-clients_2.10/1.3-SNAPSHOT/flink-clients_2.10-1.3-20170428.120310-111.pom
 (7.7 kB at 208 kB/s)
Downloading: 
https://repository.apache.org/snapshots/org/apache/flink/flink-runtime_2.10/1.3-SNAPSHOT/maven-metadata.xml
Downloaded: 
https://repository.apache.org/snapshots/org/apache/flink/flink-runtime_2.10/1.3-SNAPSHOT/maven-metadata.xml
 (1.4 kB at 30 kB/s)
Downloading: 
https://repository.apache.org/snapshots/org/apache/flink/flink-runtime_2.10/1.3-SNAPSHOT/flink-runtime_2.10-1.3-20170428.120229-111.pom
Downloaded: 
https://repository.apache.org/snapshots/org/apache/flink/flink-runtime_2.10/1.3-SNAPSHOT/flink-runtime_2.10-1.3-20170428.120229-111.pom
 (14 kB at 368 kB/s)
Downloading: 
https://repository.apache.org/snapshots/org/apache/flink/flink-optimizer_2.10/1.3-SNAPSHOT/maven-metadata.xml
Downloaded: 
https://repository.apache.org/snapshots/org/apache/flink/flink-optimizer_2.10/1.3-SNAPSHOT/maven-metadata.xml
 (1.4 kB at 36 kB/s)
Downloading: 
https://repository.apache.org/snapshots/org/apache/flink/flink-optimizer_2.10/1.3-SNAPSHOT/flink-optimizer_2.10-1.3-20170428.120253-111.pom
Downloaded: 
https://repository.apache.org/snapshots/org/apache/flink/flink-optimizer_2.10/1.3-SNAPSHOT/flink-optimizer_2.10-1.3-20170428.120253-111.pom
 (4.4 kB at 118 kB/s)

[INFO] --- maven-remote-resources-plugin:1.5:process (process-resource-bundles) 
@ flink-examples-streaming_2.11 ---
Downloading: 
https://repository.apache.org/snapshots/org/apache/flink/flink-optimizer_2.10/1.3-SNAPSHOT/flink-optimizer_2.10-1.3-20170428.120253-111.jar
Downloading: 
https://repository.apache.org/snapshots/org/apache/flink/flink-runtime_2.10/1.3-SNAPSHOT/flink-runtime_2.10-1.3-20170428.120229-111.jar
Downloading: 
https://repository.apache.org/snapshots/org/apache/flink/flink-clients_2.10/1.3-SNAPSHOT/flink-clients_2.10-1.3-20170428.120310-111.jar
Downloaded: 
https://repository.apache.org/snapshots/org/apache/flink/flink-clients_2.10/1.3-SNAPSHOT/flink-clients_2.10-1.3-20170428.120310-111.jar
 (94 kB at 1.5 MB/s)
Downloaded: 
https://repository.apache.org/snapshots/org/apache/flink/flink-optimizer_2.10/1.3-SNAPSHOT/flink-optimizer_2.10-1.3-20170428.120253-111.jar
 (2.7 MB at 14 MB/s)
Downloaded: 
https://repository.apache.org/snapshots/org/apache/flink/flink-runtime_2.10/1.3-SNAPSHOT/flink-runtime_2.10-1.3-20170428.120229-111.jar
 (6.6 MB at 16 MB/s)
{noformat}

On master this section is empty:

{noformat}
[INFO] --- maven-remote-resources-plugin:1.5:process (process-resource-bundles) 
@ flink-tests_2.11 ---
{noformat}

> Use scala.binary.version in place of change-scala-version.sh
> ------------------------------------------------------------
>
>                 Key: FLINK-6414
>                 URL: https://issues.apache.org/jira/browse/FLINK-6414
>             Project: Flink
>          Issue Type: Improvement
>          Components: Build System
>    Affects Versions: 1.3.0
>            Reporter: Greg Hogan
>            Assignee: Greg Hogan
>
> Recent commits have failed to modify {{change-scala-version.sh}} resulting in 
> broken builds for {{scala-2.11}}. It looks like we can remove the need for 
> this script by replacing hard-coded references to the Scala version with 
> Flink's maven variable {{scala.binary.version}}.
> I had initially realized that the change script is [only used for 
> building|https://ci.apache.org/projects/flink/flink-docs-release-1.3/setup/building.html#scala-versions]
>  and not for switching the IDE environment.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to