[ 
https://issues.apache.org/jira/browse/FLINK-5969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15993057#comment-15993057
 ] 

ASF GitHub Bot commented on FLINK-5969:
---------------------------------------

Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3778#discussion_r114342323
  
    --- Diff: 
flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/SavepointMigrationTestBase.java
 ---
    @@ -208,11 +190,37 @@ protected final void restoreAndExecute(
                JobSubmissionResult jobSubmissionResult = 
cluster.submitJobDetached(jobGraph);
     
                StandaloneClusterClient clusterClient = new 
StandaloneClusterClient(cluster.configuration());
    +           JobListeningContext jobListeningContext = 
clusterClient.connectToJob(jobSubmissionResult.getJobID());
     
                boolean done = false;
                while (DEADLINE.hasTimeLeft()) {
    +
    +                   // try and get a job result, this will fail if the job 
already failed. Use this
    +                   // to get out of this loop
    +                   JobID jobId = jobSubmissionResult.getJobID();
    +                   FiniteDuration timeout = FiniteDuration.apply(5, 
TimeUnit.SECONDS);
    +
    +                   try {
    +
    +                           Future<Object> future = 
Patterns.ask(clusterClient.getJobManagerGateway().actor(),
    --- End diff --
    
    Changing


> Add savepoint backwards compatibility tests from 1.2 to 1.3
> -----------------------------------------------------------
>
>                 Key: FLINK-5969
>                 URL: https://issues.apache.org/jira/browse/FLINK-5969
>             Project: Flink
>          Issue Type: Improvement
>          Components: Tests
>    Affects Versions: 1.3.0
>            Reporter: Aljoscha Krettek
>            Assignee: Aljoscha Krettek
>            Priority: Blocker
>             Fix For: 1.3.0
>
>
> We currently only have tests that test migration from 1.1 to 1.3, because we 
> added these tests when releasing Flink 1.2.
> We have to copy/migrate those tests:
>  - {{StatefulUDFSavepointMigrationITCase}}
>  - {{*MigrationTest}}
>  - {{AbstractKeyedCEPPatternOperator}}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to