Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/678#issuecomment-105287317
Hey @andralungu,
first of all, you can always discuss implementation details by starting a
thread in the mailing list. This is usually done for bigger changes, so that we
can all agree before we start coding, instead of discovering disagreements
during review. For small changes like this one, you can simply discuss
implementation on the corresponding JIRA if you want or go ahead and implement
the change and wait for the review :)
Second, my suggestions here are merely that: suggestions :) If you feel
that what I'm suggesting doesn't make sense or you have a better idea, please
discuss your view first before you start coding!
Regarding compatibility, if a method is badly designed or can be improved,
now is the time to fix it. Gelly is not even released yet, so -fortunately- we
still have the time to improve things :)
Finally, regarding the `difference` method, I meant a method that computes
the difference of two graphs and returns a new graph containing the vertices
and edges that the input graphs don't have in common. The idea is that when the
user is dealing with lots of vertices / edges (DataSets), they can use `union`
for additions and `difference` for removals. When the vertices / edges to be
added / removed fit in a List, then the user can use the add/remove methods.
Makes sense?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
