[
https://issues.apache.org/jira/browse/FLINK-5884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15997627#comment-15997627
]
ASF GitHub Bot commented on FLINK-5884:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3808#discussion_r114899203
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetCalc.scala
---
@@ -83,24 +86,28 @@ class DataSetCalc(
val inputDS =
getInput.asInstanceOf[DataSetRel].translateToPlan(tableEnv)
- val returnType = FlinkTypeFactory.toInternalRowTypeInfo(getRowType)
-
val generator = new CodeGenerator(config, false, inputDS.getType)
+ val rowTypeInfo =
FlinkTypeFactory.toInternalRowTypeInfo(getRowType).asInstanceOf[RowTypeInfo]
+
val body = functionBody(
generator,
- inputDS.getType,
- getRowType,
+ new RowSchema(getInput.getRowType),
+ new RowSchema(getRowType),
calcProgram,
config)
val genFunction = generator.generateFunction(
ruleDescription,
classOf[FlatMapFunction[Row, Row]],
body,
- returnType)
+ rowTypeInfo)
+
+ val runner = new FlatMapRunner[Row, Row](
--- End diff --
why not keeping `calcMapFunction`? It should do the same.
> Integrate time indicators for Table API & SQL
> ---------------------------------------------
>
> Key: FLINK-5884
> URL: https://issues.apache.org/jira/browse/FLINK-5884
> Project: Flink
> Issue Type: New Feature
> Components: Table API & SQL
> Reporter: Timo Walther
> Assignee: Timo Walther
> Priority: Blocker
> Fix For: 1.3.0
>
>
> We already discussed the need for a proper integration of time indicators
> (event-time or processing-time) for both the Table API & SQL on the ML:
> http://apache-flink-mailing-list-archive.1008284.n3.nabble.com/DISCUSS-Table-API-SQL-indicators-for-event-and-processing-time-tp15927.html
> This issue will track the progress. I will work on a design document how we
> can solve this issue.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
