Github user ifndef-SleePy commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3810#discussion_r115170542
  
    --- Diff: 
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/MultipleProgramsTestBase.java
 ---
    @@ -80,29 +80,36 @@
        
        protected final TestExecutionMode mode;
     
    -   
    +   private TestEnvironment testEnvironment;
    +
    +   private CollectionTestEnvironment collectionTestEnvironment;
    +
        public MultipleProgramsTestBase(TestExecutionMode mode) {
                this.mode = mode;
    -           
    +
                switch(mode){
                        case CLUSTER:
    -                           new TestEnvironment(cluster, 4).setAsContext();
    +                           testEnvironment = new TestEnvironment(cluster, 
4);
    --- End diff --
    
    Thank you for responding. Last my comment is not correct. Actually what I 
want to say is that we can not move these code to \@BeforeClass and 
\@AfterClass. But we can move them to \@Before and \@After, however it will 
bring a little overhead since \@Before and \@After will be called for each test 
method. I pushed a new commit using \@Before and \@After.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to