[ 
https://issues.apache.org/jira/browse/FLINK-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16004916#comment-16004916
 ] 

ASF GitHub Bot commented on FLINK-5256:
---------------------------------------

Github user DmytroShkvyra commented on the issue:

    https://github.com/apache/flink/pull/3673
  
    @fhueske 
    
    > When I tried to change some of the test cases to use inequality 
predicates (e.g., a < cnt), I notice that these joins are "blocked" by the 
FlinkLogicalJoinConverter rule.
    
    We should
    
        change that rule to also convert joins that can be translated by the 
SingleRowJoin (LEFT / RIGHT joins with a single row on the inner side).
        adapt all test cases to use inequality predicates to enforce 
SingleRowJoins. Some of the current tests will simply use the default join, 
which is not what we want to test here.
    
    What do you think?


> Extend DataSetSingleRowJoin to support Left and Right joins
> -----------------------------------------------------------
>
>                 Key: FLINK-5256
>                 URL: https://issues.apache.org/jira/browse/FLINK-5256
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>    Affects Versions: 1.2.0
>            Reporter: Fabian Hueske
>            Assignee: Dmytro Shkvyra
>
> The {{DataSetSingleRowJoin}} is a broadcast-map join that supports arbitrary 
> inner joins where one input is a single row.
> I found that Calcite translates certain subqueries into non-equi left and 
> right joins with single input. These cases can be handled if the  
> {{DataSetSingleRowJoin}} is extended to support outer joins on the 
> non-single-row input, i.e., left joins if the right side is single input and 
> vice versa.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to