Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3915#discussion_r116674925
--- Diff:
flink-connectors/flink-connector-kafka-0.9/src/main/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumer09.java
---
@@ -181,12 +181,6 @@ public FlinkKafkaConsumer09(List<String> topics,
KeyedDeserializationSchema<T> d
boolean useMetrics = !PropertiesUtil.getBoolean(properties,
KEY_DISABLE_METRICS, false);
- // make sure that auto commit is disabled when our offset
commit mode is ON_CHECKPOINTS;
- // this overwrites whatever setting the user configured in the
properties
- if (offsetCommitMode == OffsetCommitMode.ON_CHECKPOINTS ||
offsetCommitMode == OffsetCommitMode.DISABLED) {
-
properties.setProperty(ConsumerConfig.ENABLE_AUTO_COMMIT_CONFIG, "false");
- }
--- End diff --
This shouldn't be removed (I assume you accidentally removed it when
rebasing?).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
