[
https://issues.apache.org/jira/browse/FLINK-6598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16012162#comment-16012162
]
ASF GitHub Bot commented on FLINK-6598:
---------------------------------------
GitHub user sunjincheng121 opened a pull request:
https://github.com/apache/flink/pull/3922
[FLINK-6598][table] Fix `DataStreamGroupAggregateRule` and `DataStrea…
The changes of this PR. is modify the `matches` method of
`DataStreamGroupAggregateRule` and `DataStreamGroupWindowAggregateRule`. Add
the `!agg.getAggCallList.isEmpty` condition.
- [x] General
- The pull request references the related JIRA issue
("[FLINK-6598][table] Fix `DataStreamGroupAggregateRule` and
`DataStreamGroupWindowAggregateRule` matches error.")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the
JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sunjincheng121/flink FLINK-6598-PR
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3922.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3922
----
commit c89882112b7d1b4041733d22ec7f0d459b08af9a
Author: sunjincheng121 <[email protected]>
Date: 2017-05-16T11:08:11Z
[FLINK-6598][table] Fix `DataStreamGroupAggregateRule` and
`DataStreamGroupWindowAggregateRule` matches error.
----
> Fix `DataStreamGroupAggregateRule` matches error.
> -------------------------------------------------
>
> Key: FLINK-6598
> URL: https://issues.apache.org/jira/browse/FLINK-6598
> Project: Flink
> Issue Type: Bug
> Components: Table API & SQL
> Reporter: sunjincheng
> Assignee: sunjincheng
> Fix For: 1.3.0
>
>
> Change {{DataStreamGroupWindowAggregateRule}} and
> {{DataStreamGroupAggregateRule}} retrun from {{!distinctAggs && !groupSets &&
> !agg.indicator}} to {{!distinctAggs && !groupSets && !agg.indicator &&
> !agg.getAggCallList.isEmpty}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
