[ https://issues.apache.org/jira/browse/FLINK-6583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16012389#comment-16012389 ]
ASF GitHub Bot commented on FLINK-6583: --------------------------------------- Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3919#discussion_r116729795 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/triggers/CountTriggerWithCleanupState.scala --- @@ -0,0 +1,146 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.flink.table.runtime.triggers + +import java.lang.{Long => JLong} + +import org.apache.flink.api.common.functions.ReduceFunction +import org.apache.flink.api.common.state._ +import org.apache.flink.streaming.api.windowing.triggers.Trigger.TriggerContext +import org.apache.flink.streaming.api.windowing.triggers.{Trigger, TriggerResult} +import org.apache.flink.streaming.api.windowing.windows.Window +import org.apache.flink.table.api.{StreamQueryConfig, Types} +import org.apache.flink.table.runtime.triggers.CountTriggerWithCleanupState.Sum + +class CountTriggerWithCleanupState[W <: Window](queryConfig: StreamQueryConfig, maxCount: Long) --- End diff -- Rename to `StateCleaningCountTrigger`? > Enable QueryConfig in count base GroupWindow > -------------------------------------------- > > Key: FLINK-6583 > URL: https://issues.apache.org/jira/browse/FLINK-6583 > Project: Flink > Issue Type: New Feature > Components: Table API & SQL > Affects Versions: 1.3.0, 1.4.0 > Reporter: sunjincheng > Assignee: sunjincheng > > Enable QueryConfig in count base GroupWindow by Add a custom Trigger > `CountTriggerWithCleanupState`. See more in FLINK-6491. -- This message was sent by Atlassian JIRA (v6.3.15#6346)