Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/3928#discussion_r117144044
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/security/SecurityUtils.java
---
@@ -230,10 +231,21 @@ private void validate() {
}
private static List<String> parseList(String value) {
- if(value == null) {
+ if(value == null || value.isEmpty()) {
return Collections.emptyList();
}
- return Arrays.asList(value.split(","));
--- End diff --
The wisdom of that paragraph has been debated extensively on stackoverflow.
I'll just say that the `StringTokenizer` is not deprecated and, in my opinion,
fits this scenario uniquely well. Go ahead either way.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
