[
https://issues.apache.org/jira/browse/FLINK-6618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015464#comment-16015464
]
ASF GitHub Bot commented on FLINK-6618:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3936#discussion_r117196683
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/table/stringexpr/GroupWindowStringExpressionTest.scala
---
@@ -47,19 +47,23 @@ class GroupWindowStringExpressionTest extends
TableTestBase {
myCountFun('string),
'int.sum,
weightAvgFun('long, 'int),
- weightAvgFun('int, 'int) * 2)
+ weightAvgFun('int, 'int) * 2,
+ 'w.start,
+ 'w.end)
// String / Java API
val resJava = t
-
.window(JSlide.over("4.hours").every("2.hours").on("rowtime").as("w"))
+ .window(JSlide.over("4.hours").every("2.hours").on("rowtime") as 'w)
--- End diff --
Why are you changing `"w"` to a Scala expression `'w`? The test should
check that Strings are correctly translated to expressions .
> Fix GroupWindowStringExpressionTest testcase bug
> ------------------------------------------------
>
> Key: FLINK-6618
> URL: https://issues.apache.org/jira/browse/FLINK-6618
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Affects Versions: 1.3.0
> Reporter: sunjincheng
> Assignee: sunjincheng
>
> I find 2 bugs as follows:
> 1. {{GroupWindowStringExpressionTest}} testcase bug:
> {{Assert.assertEquals("Logical Plans do not match", resJava.logicalPlan,
> resJava.logicalPlan)}} -> {{verifyTableEquals(resJava, resScala)}}
> 2. Window properties can not select in JAVA API:
> Java Code:
> {code}
> // String / Java API
> val resJava = t
> .window(JSlide.over("4.hours").every("2.hours").on("rowtime") as 'w)
> .groupBy("w, string")
> .select(
> "string, " +
> "myCountFun(string), " +
> "int.sum, " +
> "weightAvgFun(long, int), " +
> "weightAvgFun(int, int) * 2, " +
> "start(w)," +
> "end(w)")
> {code}
> Exception Info:
> {code}
> org.apache.flink.table.api.ValidationException: Cannot resolve [w] given
> input [int, long, string, rowtime].
> at
> org.apache.flink.table.plan.logical.LogicalNode.failValidation(LogicalNode.scala:143)
> at
> org.apache.flink.table.plan.logical.LogicalNode$$anonfun$validate$1.applyOrElse(LogicalNode.scala:86)
> at
> org.apache.flink.table.plan.logical.LogicalNode$$anonfun$validate$1.applyOrElse(LogicalNode.scala:83)
> at
> org.apache.flink.table.plan.TreeNode.postOrderTransform(TreeNode.scala:72)
> at
> org.apache.flink.table.plan.logical.LogicalNode.org$apache$flink$table$plan$logical$LogicalNode$$expressionPostOrderTransform$1(LogicalNode.scala:119)
> at
> org.apache.flink.table.plan.logical.LogicalNode$$anonfun$7$$anonfun$apply$1.apply(LogicalNode.scala:132)
> at
> scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244)
> at
> scala.collection.TraversableLike$$anonfun$map$1.apply(TraversableLike.scala:244)
> at
> scala.collection.mutable.ResizableArray$class.foreach(ResizableArray.scala:59)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
