[
https://issues.apache.org/jira/browse/FLINK-6624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16015495#comment-16015495
]
ASF GitHub Bot commented on FLINK-6624:
---------------------------------------
Github user tedyu commented on the issue:
https://github.com/apache/flink/pull/3938
Lgtm
> SharedBuffer#hashCode() uses multiplier in wrong way
> ----------------------------------------------------
>
> Key: FLINK-6624
> URL: https://issues.apache.org/jira/browse/FLINK-6624
> Project: Flink
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Kostas Kloudas
> Priority: Minor
>
> In SharedBuffer.java:
> {code}
> public int hashCode() {
> return (int) (31 * (timestamp ^ timestamp >>> 32) + 31 *
> value.hashCode()) + counter;
> {code}
> Multiplier of 31 is applied to both (timestamp ^ timestamp >>> 32) and
> value.hashCode().
> The following is probably the right expression:
> {code}
> return (int) 31 * (31 * (timestamp ^ timestamp >>> 32) +
> value.hashCode()) + counter;
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
