Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3935#discussion_r117252282
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/restart/FailureRateRestartStrategy.java
 ---
    @@ -92,7 +92,7 @@ public static FailureRateRestartStrategyFactory 
createFactory(Configuration conf
                String failuresIntervalString = configuration.getString(
                                
ConfigConstants.RESTART_STRATEGY_FAILURE_RATE_FAILURE_RATE_INTERVAL, 
Duration.apply(1, TimeUnit.MINUTES).toString()
                );
    -           String timeoutString = 
configuration.getString(ConfigConstants.AKKA_WATCH_HEARTBEAT_INTERVAL, 
ConfigConstants.DEFAULT_AKKA_ASK_TIMEOUT);
    --- End diff --
    
    Yes, since it does not make much sense to set the heartbeat interval to a 
smaller value than the akka ask timeout if not explicitly set.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to