GitHub user greghogan opened a pull request:

    https://github.com/apache/flink/pull/3941

    [FLINK-6603] [streaming] Enable checkstyle on test sources

    Follow-up to FLINK-6107.
    
    The first commit sets the import order as 
[discussed](https://issues.apache.org/jira/browse/FLINK-6107?focusedCommentId=15985221&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15985221):
 first Flink imports, then other imports, then javax, then java (we could 
consider placing javax and java together; I have not looked into the required 
regex and we only have a few instances of javax). The groups are separated by a 
single newline with static imports moved to the bottom.
    
    The second commit applies the strict checkstyle to the 
`flink-streaming-java` tests. The checkstyle line length was increased from 
2500 to 3000.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/greghogan/flink 
6603_enable_checkstyle_on_test_sources

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3941.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3941
    
----
commit b71b24f4b3e9a3bb3625e698ea2db18531520379
Author: Greg Hogan <c...@greghogan.com>
Date:   2017-05-17T12:01:04Z

    Import order

commit 201ab2a6994a9be153cf08a16d3e6f317246dc33
Author: Greg Hogan <c...@greghogan.com>
Date:   2017-05-17T16:02:50Z

    Fix checkstyle violations

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to