[
https://issues.apache.org/jira/browse/FLINK-6482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16019357#comment-16019357
]
ASF GitHub Bot commented on FLINK-6482:
---------------------------------------
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3937#discussion_r117700406
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/typeutils/CompositeTypeSerializerConfigSnapshot.java
---
@@ -73,13 +91,11 @@ public boolean equals(Object obj) {
}
return (obj.getClass().equals(getClass()))
- && Arrays.equals(
- nestedSerializerConfigSnapshots,
-
((CompositeTypeSerializerConfigSnapshot)
obj).getNestedSerializerConfigSnapshots());
+ &&
nestedSerializersWithConfigs.equals(((CompositeTypeSerializerConfigSnapshot)
obj).getNestedSerializersAndConfigs());
}
@Override
public int hashCode() {
- return Arrays.hashCode(nestedSerializerConfigSnapshots);
+ return nestedSerializersWithConfigs.hashCode();
--- End diff --
Same here; `nestedSerializersWithConfigs` is a `List` not an array, the
`hashCode` implementation should suffice?
> Add nested serializers into configuration snapshots of composite serializers
> ----------------------------------------------------------------------------
>
> Key: FLINK-6482
> URL: https://issues.apache.org/jira/browse/FLINK-6482
> Project: Flink
> Issue Type: Improvement
> Components: State Backends, Checkpointing, Type Serialization System
> Reporter: Tzu-Li (Gordon) Tai
> Assignee: Tzu-Li (Gordon) Tai
> Priority: Blocker
> Fix For: 1.3.0
>
>
> Currently, the composite serializers' configuration snapshots only wrap the
> config snapshots of nested serializers.
> We should also consider adding serialization of the nested serializers into
> the config snapshot, so that in the case where only some nested serializer
> cannot be loaded (class missing / implementation changed), we can also
> provide a path for serializer upgrades.
> This applies for all composite serializers that have nested serializers.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
